Update forward relation fields in the admin to be raw id fields #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 25 25
Lines 2384 2384
Branches 222 222
=======================================
Hits 2325 2325
Misses 45 45
Partials 14 14Continue to review full report at Codecov.
|
|
Thanks! I think it can be tweaked a bit to set raw_id_fields in StripeModelAdmin? That means we're less likely to miss setting this in new models. I'll make this tweak. |
also set raw_id_fields in Inlines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue I found where some foreign key fields were not raw ID fields, potentially causing giant select widgets to be rendered in the admin.
The utility function used should automatically catch when new forward relations are added to models, and ensure those are rendered as raw id fields in the admin.