Improve Docker build support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile has been heavily modified to make full use of docker build. The operating system has been changed to Alpine Linux, and most of the old hacks we needed for exporting binaries were removed.
|
I will try it out asap, but it looks ok to me. |
|
It does not build for me, you have to add: RUN git submodule init to get the unicore-mx library. |
|
Is it a good deployment practice for Docker to perform Git commands inside a Docker container? I wasn't doing it in the first place because submodule cloning is supposed to be performed by |
|
I have not tried this actually: $ docker build https://github.com/jeanthom/DirtyJTAG.git --output type=tar,dest=dirtyjtag.tar I cloned the repo and did a 'docker build .' Will try the first method later on... |
This was referenced Nov 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96