Syntax fixes #5367
Merged
Syntax fixes #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And a very few other type related minor fixes
* Remove unnecessary escape chars in regexes * Remove unnecessary awaits * Replace deprecated req.connection with req.socket * Replace deprecated upload with uploadOne * Remove unnecessary eslint-disable-next-line comments * Comment empty functions / catch or finally clauses * Fix irregular whitespaces * Add missing returns (null) * Remove unreachable code * A few logical fixes * Remove / Handle non-null assertions which are certainly unnecessary (e.g. in tests)
|
Just as an information: With this pull request the ESLint problems have been reduced from around 750 (state from #5312 (comment)) to 360, where 175 will be automatically fixable: |
rijkvanzanten
approved these changes
Apr 29, 2021
AustinPhillipTaylor
pushed a commit
to AustinPhillipTaylor/directus
that referenced
this pull request
May 11, 2022
* Declare return types on functions And a very few other type related minor fixes * Minor syntax fixes * Remove unnecessary escape chars in regexes * Remove unnecessary awaits * Replace deprecated req.connection with req.socket * Replace deprecated upload with uploadOne * Remove unnecessary eslint-disable-next-line comments * Comment empty functions / catch or finally clauses * Fix irregular whitespaces * Add missing returns (null) * Remove unreachable code * A few logical fixes * Remove / Handle non-null assertions which are certainly unnecessary (e.g. in tests)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5254 this pull request contains only a slimmed down version of the "syntax fixes" part.
There are still many changes, but it is much clearer now and the changes should be safer and easier to be reviewed.
It is now split into two commits:
Many changes from the original pull request have been omitted:
hasOwnProperty: @rijkvanzanten IMHO I still think those should be changed toObject.prototype.hasOwnProperty.callor otherwise the corresponding eslint rule should be disabled - I don't see any advantage in changing it into'key' in transformationand didn't want to waste my time on thisI've checked all the changes again to make sure everything is alright and rebased it on latest state from main branch.
I really hope you can use this pull request as I've now put quite a lot of effort into it 😃 Thanks!