Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes framework target error #90

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Fixes framework target error #90

merged 1 commit into from
Aug 25, 2019

Conversation

nebiros
Copy link
Contributor

@nebiros nebiros commented Aug 25, 2019 •
edited
Loading

Fixes framework target error, this target it's not set to swift5,
causing an error with carthage

What does this PR do?

Fixes framework target error, this target it's not set to swift5,
causing an error with carthage

What issues (if any) are related to this PR? Or why was this change introduced?

$ carthage update --platform iOS
*** Building scheme "SwiftVideoBackground-iOS" in SwiftVideoBackground.xcodeproj
Build Failed
	Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -project /Users/nebiros/ios/studio-ios/Carthage/Checkouts/SwiftVideoBackground/SwiftVideoBackground.xcodeproj -scheme SwiftVideoBackground-iOS -configuration Release -derivedDataPath /Users/nebiros/Library/Caches/org.carthage.CarthageKit/DerivedData/10.3_10G8/SwiftVideoBackground/3.4.0 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/bg/q5lvd51j5qz4jhrrfbfs3ycr0000gn/T/SwiftVideoBackground SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/nebiros/ios/studio-ios/Carthage/Checkouts/SwiftVideoBackground)

Checklist

  • Does this contain code changes?
  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@nebiros
Fixes framework target error
a10f202 
Fixes framework target error, this target it's not set to swift5,
causing an error with carthage
@dingwilsonbot
Copy link

1 Message
📖 Executed 7 tests, with 0 failures (0 unexpected) in 0.039 (0.372) seconds

Generated by 🚫 Danger

@dingwilson
Copy link
Owner

Nice catch! Thank you for your fix. 🚀

@dingwilson dingwilson merged commit 2255c77 into dingwilson:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingwilson dingwilson dingwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nebiros @dingwilsonbot @dingwilson