Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

84: added support of 'preventsDisplaySleepDuringVideoPlayback' proper… #86

Merged
merged 3 commits into from
Aug 18, 2019
Merged

84: added support of 'preventsDisplaySleepDuringVideoPlayback' proper… #86

merged 3 commits into from
Aug 18, 2019

Conversation

blbnv
Copy link
Contributor

@blbnv blbnv commented Jul 22, 2019

What does this PR do?

This PR adds support of preventsDisplaySleepDuringVideoPlayback property to allow device lock automatically when video is played.
Applied only for iOS 12.0+

What issues (if any) are related to this PR? Or why was this change introduced?

#84

Checklist

  • Does this contain code changes?
  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@dingwilsonbot
Copy link

dingwilsonbot commented Jul 22, 2019

1 Message
📖 Executed 7 tests, with 0 failures (0 unexpected) in 0.102 (0.115) seconds

Generated by 🚫 Danger

Copy link
Owner

@dingwilson dingwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for your contribution to SwiftVideoBackground! 🚀

Once you merge this PR, I will cut a new release with this feature.

@dingwilson
Copy link
Owner

Hey @blbnv! Is this change ready to be merged?

@blbnv
Copy link
Contributor Author

blbnv commented Aug 9, 2019

hi @dingwilson sorry I missed to reply... yes this is ready. can you please merge this pull reuqest to your repo?

@dingwilson dingwilson merged commit a63c7cb into dingwilson:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants