Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not found bug #900

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix not found bug #900

merged 2 commits into from
May 16, 2024

Conversation

saadman-galib
Copy link
Contributor

@saadman-galib saadman-galib commented May 16, 2024 •
edited by pranshugupta54
Loading

Pull Request Details

Description

[Provide a brief overview of the changes introduced by this pull request.]

Fixes

fixes #890

Type of PR

  • Bug fix

Summary

Added not found for contests, challenges and hackathons

Screenshots (if applicable)

Screenshot_2024-05-16_23-20-39
Screenshot_2024-05-16_23-54-10
Screenshot_2024-05-16_23-53-51

Checklist

  • I have read and followed the Pull Requests and Issues guidelines.
  • The code has been properly linted and formatted using npm run lint:fix and npm run format:fix.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, snapshots, and videos after making the changes.
  • I have not borrowed code without disclosing it, if applicable.
  • This pull request is not a Work In Progress (WIP), and only completed and tested changes are included.
  • I have tested these changes locally.
  • My code follows the project's style guidelines.
  • I have updated the documentation accordingly.
  • This PR has a corresponding issue in the issue tracker.

Summary by CodeRabbit

  • New Features
    • Added messages to indicate when no contests, challenges, or hackathons are found.

@netlify Netlify
Copy link

netlify bot commented May 16, 2024 •
edited
Loading

👷 Deploy request for digitomize pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f262f9b

@netlify Netlify
Copy link

netlify bot commented May 16, 2024 •
edited
Loading

👷 Deploy request for v2-digitomize pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f262f9b

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 16, 2024 •
edited
Loading

Walkthrough

The recent changes focus on enhancing user experience by providing clear feedback when no contests, challenges, or hackathons are available. The updates involve adding conditional rendering logic to display appropriate messages in the components, ensuring users are informed when no items are found.

Changes

Files Change Summary
client/src/components/Contests*.jsx Added conditional rendering to display messages when no contests are found.
client/src/components/Contests/Challenges/Challenges.jsx Updated conditional rendering to show messages when no challenges are available.
client/src/components/Contests/Hackathons/HackathonsFilter.jsx Implemented conditional rendering to display "No Hackathons Found" message when none are found.

🐰
When contests are scarce and challenges few,
Our code now whispers, "There's nothing new."
Hackathons absent, don't be dismayed,
A friendly message will be displayed.
With thoughtful tweaks, our UI's bright,
Bringing clarity to your sight.
🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 56870e2 and a9c9483.
Files selected for processing (3)
  • client/src/components/Contests.jsx (1 hunks)
  • client/src/components/Contests/Challenges/Challenges.jsx (1 hunks)
  • client/src/components/Contests/Hackathons/HackathonsFilter.jsx (1 hunks)
Files skipped from review due to trivial changes (3)
  • client/src/components/Contests.jsx
  • client/src/components/Contests/Challenges/Challenges.jsx
  • client/src/components/Contests/Hackathons/HackathonsFilter.jsx

@pranshugupta54
Copy link
Member

@saadman-galib, how about using some svg design too? Example:

Goto: https://digitomize.com/jobs

@saadman-galib
Copy link
Contributor Author

@pranshugupta54
Will i use the same svg?
Or i will use a similar icon for not found from https://iconscout.com/
iconscout com_free-illustration_page-not-found-4085802
iconscout com_free-illustration_empty-cart-4085814

https://iconscout.com/free-illustration/page-not-found-4085802
https://iconscout.com/free-illustration/empty-cart-4085814

@pranshugupta54
Copy link
Member

You can use the same svg or get a new svg with same color theme

@saadman-galib
Copy link
Contributor Author

Check pls. which one is good
image
image
image
image
image

https://www.freepik.com/free-vector/flat-design-no-data-illustration_47718912.htm#query=no%20data&position=4&from_view=keyword&track=ais_user&uuid=a91154ba-4b35-4b69-8ec9-a4df81d55575
https://www.freepik.com/free-vector/hand-drawn-no-data-concept_55024598.htm#query=no%20data&position=2&from_view=keyword&track=ais_user&uuid=a91154ba-4b35-4b69-8ec9-a4df81d55575
https://www.freepik.com/free-vector/data-monetization-abstract-concept-vector-illustration-data-business-strategy-information-monetization-monetizing-data-services-selling-database-source-analysis-abstract-metaphor_11669386.htm#fromView=search&page=5&position=22&uuid=f56d9a7a-cfd6-41b1-b424-cd51bd6a7af0
https://www.freepik.com/free-vector/oops-404-error-with-broken-robot-concept-illustration_8030430.htm#fromView=search&page=1&position=29&uuid=f56d9a7a-cfd6-41b1-b424-cd51bd6a7af0
https://www.freepik.com/free-vector/error-404-concept-landing-page_5155989.htm#fromView=search&page=1&position=4&uuid=f56d9a7a-cfd6-41b1-b424-cd51bd6a7af0

@pranshugupta54
Copy link
Member

Can you re-color those?

@saadman-galib
Copy link
Contributor Author

I don't have any experience in design. That's why I can't do it

@pranshugupta54
Copy link
Member

Ohk, you can use the svgs which we're currently using on other screens

@saadman-galib
Copy link
Contributor Author

saadman-galib commented May 16, 2024 •
edited
Loading

Is it okay?
image

@pranshugupta54
Copy link
Member

looks good

coderabbitai[bot]
coderabbitai bot reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a9c9483 and f262f9b.
Files selected for processing (3)
  • client/src/components/Contests.jsx (2 hunks)
  • client/src/components/Contests/Challenges/Challenges.jsx (2 hunks)
  • client/src/components/Contests/Hackathons/HackathonsFilter.jsx (2 hunks)
Files skipped from review as they are similar to previous changes (3)
  • client/src/components/Contests.jsx
  • client/src/components/Contests/Challenges/Challenges.jsx
  • client/src/components/Contests/Hackathons/HackathonsFilter.jsx

@pranshugupta54 pranshugupta54 merged commit 0d4d891 into digitomize:main May 16, 2024
6 of 9 checks passed
@pranshugupta54
Copy link
Member

🚀 Congratulations on the successful PR merge! 🌟
Thank you for your valuable contribution! 🎉
Let's continue to make waves in open source. Share your achievement on social media and tag Digitomize to help spread the word.

Thank you for your dedication!

@all-contributors please add @saadman-galib for code

@holopin-bot @saadman-galib c-ch

@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented May 16, 2024

Congratulations @saadman-galib, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clw9neqj810600gmmofbna0qd

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@allcontributors allcontributors bot mentioned this pull request May 16, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@pranshugupta54

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @saadman-galib! 🎉

@saadman-galib saadman-galib deleted the bug/not-found branch May 16, 2024 19:34
@coderabbitai coderabbitai bot mentioned this pull request Jan 11, 2025
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
gssoc level2 title needs formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Not Showing no contest found
2 participants
@saadman-galib @pranshugupta54