vpcs: Support listing members of a VPC. #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiefMateStarbuck
previously approved these changes
Mar 25, 2021
| @@ -214,3 +231,35 @@ func (v *VPCsServiceOp) Delete(ctx context.Context, id string) (*Response, error | |||
|
|
|||
| return resp, nil | |||
| } | |||
|
|
|||
| func (v *VPCsServiceOp) ListMembers(ctx context.Context, id string, request *VPCListMembersRequest, opt *ListOptions) ([]*VPCMember, *Response, error) { | |||
There was a problem hiding this comment.
Golang question: Is it a paradigm that interface functions return pointers and not actual values?
There was a problem hiding this comment.
Not necessarily, but it's the general pattern we're using in godo.
| @@ -15,6 +15,7 @@ type VPCsService interface { | |||
| Create(context.Context, *VPCCreateRequest) (*VPC, *Response, error) | |||
| Get(context.Context, string) (*VPC, *Response, error) | |||
| List(context.Context, *ListOptions) ([]*VPC, *Response, error) | |||
| ListMembers(context.Context, string, *VPCListMembersRequest, *ListOptions) ([]*VPCMember, *Response, error) | |||
There was a problem hiding this comment.
Interesting that it's never been implemented!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this method was never implemented:
https://developers.digitalocean.com/documentation/v2/#list-the-member-resources-of-a-vpc