kubernetes - support optional cascading deletes #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisLaw
previously approved these changes
Jan 14, 2021
| } | ||
|
|
||
| expectedReqJSON := `{"volumes":["2241"],"volume_snapshots":["7258"],"load_balancers":["9873"]} | ||
| ` |
There was a problem hiding this comment.
nit: should this char be on a separate line or can it go right after the ending curly brace?
ChiefMateStarbuck
suggested changes
Jan 14, 2021
varshavaradarajan
force-pushed
the
varsha/associated-resources
branch
from
e8ff619 to
e338f54
Compare
|
Great Work @varshavaradarajan! @MorrisLaw, could I get an approval? |
ChiefMateStarbuck
previously approved these changes
Jan 15, 2021
varshavaradarajan
force-pushed
the
varsha/associated-resources
branch
from
e338f54 to
9ddf791
Compare
varshavaradarajan
requested review from
andrewsomething and
ChiefMateStarbuck
andrewsomething
approved these changes
Jan 15, 2021
ChiefMateStarbuck
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support list associated resources for deletion and the new cluster delete endpoints.
cc @MorrisLaw , @adamwg