kubernetes: add clusterlint support #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshavaradarajan
force-pushed
the
clusterlint-support
branch
from
a63cf25 to
32f38d1
Compare
adamwg
previously approved these changes
Nov 17, 2020
kubernetes.go
Outdated
Comment on lines
853
to
857
| resp, err := svc.client.Do(ctx, request, nil) | ||
| if err != nil { | ||
| return resp, err | ||
| } | ||
| return resp, nil |
There was a problem hiding this comment.
Do we want to return a object containing the results here?
There was a problem hiding this comment.
@andrewsomething - thank you, updated GetClusterlintResults. Can you please merge and release this if everything looks alright to you?
There was a problem hiding this comment.
I can create the changelog PR once you merge.
There was a problem hiding this comment.
Merged! Happy to tag a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to run clusterlint and fetch diagnostics.
cc @adamwg