Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: add the option to force build a new deployment #407

Merged
merged 3 commits into from
Nov 5, 2020
Merged

apps: add the option to force build a new deployment #407

merged 3 commits into from
Nov 5, 2020

Conversation

kamaln7
Copy link
Contributor

@kamaln7 kamaln7 commented Nov 3, 2020 •
edited
Loading

cURL usage:

curl \
    -H "Content-Type: application/json" \
    -H "Authorization: Bearer TOKEN" \
    "https://api.digitalocean.com/v2/apps/ID/deployments" \
    -XPOST \
    -d '{"force_build": true}'

@kamaln7 kamaln7 marked this pull request as draft November 3, 2020 15:05
@kamaln7 kamaln7 force-pushed the apps-create-deployment branch from c73ca04 to a318797 Compare November 3, 2020 15:10
@kamaln7 kamaln7 marked this pull request as ready for review November 3, 2020 15:10
bentranter
bentranter reviewed Nov 4, 2020
View reviewed changes
apps.go Outdated Show resolved Hide resolved
bentranter
bentranter reviewed Nov 4, 2020
View reviewed changes
apps.go Outdated Show resolved Hide resolved
bentranter
bentranter reviewed Nov 4, 2020
View reviewed changes
apps.go Show resolved Hide resolved
bentranter
bentranter reviewed Nov 4, 2020
View reviewed changes
apps.go Outdated Show resolved Hide resolved
bentranter
bentranter reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions that should make this a non-breaking change without needing to change the tests, but no pressure to accept, just wanted to show what I was thinking.

@bentranter
Apply suggestions from code review
f93b1bd 
Co-authored-by: Ben Tranter <ben@bentranter.io>
@kamaln7
Copy link
Contributor Author

kamaln7 commented Nov 4, 2020

Thanks @bentranter 🙏🏼

bentranter
bentranter approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kamaln7!

@bentranter bentranter merged commit f3e2fed into digitalocean:main Nov 5, 2020
@kamaln7 kamaln7 mentioned this pull request Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamaln7 @bentranter