[droplets]: add support for droplet backup policy #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use a separate droplet action for that
andrewsomething
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Looking good. Left a few comments in-line from my first pass review. Would be great to get some integration-style tests as well.
Thinking about the overall structure, it might make sense to group these new commands together under a backup-policies sub command. Something like:
doctl compute droplet backup-policies get
doctl compute droplet backup-policies list
doctl compute droplet backup-policies list-supported
It feels a bit cleaner to me. What do you think?
loosla
commented
Nov 13, 2024
…nabling; revert changes in integration tests
…nd backup policy applied
…egration tests for droplet backup policies get
…policies for all droplets
loosla
commented
Nov 15, 2024
loosla
commented
Nov 15, 2024
andrewsomething
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds droplet backup policy to doctl.
For droplets on:
For droplet actions on:
--backup-policy)Thanks 🦈