Don't set APP_CACHE_DIR if --no-cache is passed with apps dev build #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusthoemmes
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It mounts the
/cnb/cachedirectory for caching the build.This fails to build in Github Actions since user doesn't have permission to write to /
Error message is :
Error: failed to chown volumes: chown /cnb/cache: operation not permitteddoctl apps dev buildhas a flag--no-cachewhich disables the caching docs-link.But this is not being used for buildpack-based builds.
This PR fixes this behavior to disable caching when
--no-cacheis set.