Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[databases]: add support for Kafka advanced configuration #1587

Merged
merged 4 commits into from
Sep 26, 2024
Merged

[databases]: add support for Kafka advanced configuration #1587

merged 4 commits into from
Sep 26, 2024

Conversation

loosla
Copy link
Contributor

@loosla loosla commented Sep 26, 2024

This PR is adding a support for Kafka advanced configuration: Get, Update.

Command examples to test

doctl databases configuration get <db-cluster-id> -e kafka

doctl databases configuration update <db-cluster-id> -e kafka --config-json '{"group_initial_rebalance_delay_ms":2000}'

andrewsomething
andrewsomething requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small thing, for the big.Int fields we shouldn't use the Go value in the displayer. The output ends up looking like:

LogRetentionBytes                     {true [1]}
LogRetentionMs                        {false [604800000]}

Suggestion in-line for the ones I noticed.

commands/displayers/database.go Outdated Show resolved Hide resolved
commands/displayers/database.go Outdated Show resolved Hide resolved
loosla and others added 2 commits September 26, 2024 13:28
@loosla @andrewsomething
Update commands/displayers/database.go
255e997 
Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
@loosla @andrewsomething
Update commands/displayers/database.go
bbd3cc3 
Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
@loosla
Copy link
Contributor Author

loosla commented Sep 26, 2024

Thanks a lot, Andrew 👍
Now it looks right 🚀
Screenshot from 2024-09-26 13-32-55

andrewsomething
andrewsomething approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@loosla loosla merged commit de1fb73 into main Sep 26, 2024
8 checks passed
@loosla loosla deleted the alushnikova/add-kafka-advanced-conf branch September 26, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

@bentranter bentranter Awaiting requested review from bentranter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loosla @andrewsomething