-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scalable storage for PostgreSQL/MySQL databases #1454
Merged
andrewsomething
merged 2 commits into
digitalocean:main
from
dweinshenker:dbaas-scalable-storage
Oct 30, 2023
Merged
Support scalable storage for PostgreSQL/MySQL databases #1454
andrewsomething
merged 2 commits into
digitalocean:main
from
dweinshenker:dbaas-scalable-storage
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just a bit of a nitpick about the displayer.
andrewsomething
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dweinshenker
added a commit
to dweinshenker/doctl
that referenced
this pull request
Nov 14, 2023
…#1454) * Support scalable storage for PostgreSQL/MySQL databases * update displayer to be consistent between short/long versions
danaelhe
added a commit
that referenced
this pull request
Nov 17, 2023
* update interface for godo methods * add topic config displayer * add support for listing partitions * rename variables * add ability to specific advanced configuration when creating/updating * add update functionality * add tests and mocks * Support scalable storage for PostgreSQL/MySQL databases (#1454) * Support scalable storage for PostgreSQL/MySQL databases * update displayer to be consistent between short/long versions * build(deps): bump github.com/docker/docker (#1456) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.5+incompatible to 24.0.7+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.5...v24.0.7) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove unclean_leader_election_enable * Update args.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> * Update commands/databases.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> * Update commands/databases.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> * Update commands/databases.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> * Update commands/databases.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> * Update commands/databases.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> * Update commands/databases.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> * Update commands/databases.go Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
--storage-size-mib
when doing CreateCluster or ResizeCluster operations on a database