Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scalable storage for PostgreSQL/MySQL databases #1454

Merged

Conversation

dweinshenker
Copy link
Contributor

@dweinshenker dweinshenker commented Oct 26, 2023

What

  • Adds the ability to provide --storage-size-mib when doing CreateCluster or ResizeCluster operations on a database
  • Includes the StorageSizeMib as a column in the databases display output

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a bit of a nitpick about the displayer.

commands/displayers/database.go Outdated Show resolved Hide resolved
commands/displayers/database.go Outdated Show resolved Hide resolved
@andrewsomething andrewsomething self-requested a review October 30, 2023 17:59
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewsomething andrewsomething merged commit 38f2044 into digitalocean:main Oct 30, 2023
6 checks passed
dweinshenker added a commit to dweinshenker/doctl that referenced this pull request Nov 14, 2023
…#1454)

* Support scalable storage for PostgreSQL/MySQL databases

* update displayer to be consistent between short/long versions
danaelhe added a commit that referenced this pull request Nov 17, 2023
* update interface for godo methods

* add topic config displayer

* add support for listing partitions

* rename variables

* add ability to specific advanced configuration when creating/updating

* add update functionality

* add tests and mocks

* Support scalable storage for PostgreSQL/MySQL databases (#1454)

* Support scalable storage for PostgreSQL/MySQL databases

* update displayer to be consistent between short/long versions

* build(deps): bump github.com/docker/docker (#1456)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.5+incompatible to 24.0.7+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v24.0.5...v24.0.7)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* remove unclean_leader_election_enable

* Update args.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

* Update commands/databases.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

* Update commands/databases.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

* Update commands/databases.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

* Update commands/databases.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

* Update commands/databases.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

* Update commands/databases.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

* Update commands/databases.go

Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: danaelhe <42972711+danaelhe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants