changes to support usage in serverless backend development #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddebarros
previously approved these changes
Nov 7, 2022
ddebarros
reviewed
Nov 11, 2022
| credentials, _ := c.Doit.GetBool(c.NS, "credentials") | ||
| if credentials { | ||
| type showCreds struct { | ||
| Auth string `json:auth` |
There was a problem hiding this comment.
@joshuaauerbachwatson can we also include the path to the credentials here ? It would be very useful when running the deployer tests.
There was a problem hiding this comment.
@ddebarros I have added the path to the credentials output. To do this cleanly I added to the ServerlessService which in turn required regenerating the mocks. This led me to thinking whether we should expand unit tests to cover these paths, so I may do that also before requesting review again.
ddebarros
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A corollary to recent efforts to reduce dependence on the serverless plugin: we are also trying to eliminate internal usages of
nimin our own development processes, replacing it withdoctl. In order for that to work,doctlneeds some enhancements to work with serverless backend clusters that are not in production (and hence not (yet) known to the portal).The changes are all in the area of credential management. Basically, they allow both setting and interrogating credentials via their low-level OpenWhisk characteristics without using the namespace APIs.
Only those commands whose
nimequivalents are actually used in this way have been changed. The additional flags are all hidden, since this low-level credential manipulation is not something DigitalOcean customers would ordinarily do (although there is nothing insecure about it). Having these features show up in help texts would be distracting and might lead to the impression that this feature had an important mainstream use case.