Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows test skipping #9881

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix Windows test skipping #9881

merged 1 commit into from
Jun 2, 2021

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented Jun 2, 2021 •
edited
Loading

= doesn’t seem to work. -ceq is case insensitive comparison. I think
-eq would also work here but I see no point in worrying about case.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@cocreature
Fix Windows test skipping
37f95a6 
= doesn’t seem to work. -ceq is case insensitive comparison. I think
-eq would also work here but I see no point in worrying about case.

changelog_begin
changelog_end
@cocreature cocreature force-pushed the debug-windows-skip branch from 8506b03 to 37f95a6 Compare June 2, 2021 10:03
@cocreature cocreature changed the title Debug windows skip thingy Fix Windows test skipping Jun 2, 2021
@cocreature cocreature marked this pull request as ready for review June 2, 2021 10:04
garyverhaegen-da
garyverhaegen-da approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean we've been skipping all Windows tests all the time ever since that got merged? 🤔

@cocreature
Copy link
Contributor Author

Does that mean we've been skipping all Windows tests all the time ever since that got merged? thinking

Nope, it seems to always evaluate to false luckily rather than true

@mergify mergify bot merged commit 0c514b3 into main Jun 2, 2021
@mergify mergify bot deleted the debug-windows-skip branch June 2, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @garyverhaegen-da