skip Windows tests on release #9656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair warning: I have no idea how either YAML or PowerShell programming works. 🤷 |
cocreature
approved these changes
May 12, 2021
| @@ -59,4 +59,6 @@ bazel build `-`-experimental_execution_log_file ${ARTIFACT_DIRS}/logs/build_exec | |||
|
|
|||
| bazel shutdown | |||
|
|
|||
| bazel test `-`-experimental_execution_log_file ${ARTIFACT_DIRS}/logs/test_execution_windows.log //... | |||
| if ($env:SKIP_TESTS = "False") { | |||
There was a problem hiding this comment.
Maybe worth adding a comment here or in the yaml file documenting that
- We only do this for release builds where the PR (should) run exactly the same tests as the build on main.
- The reason why release builds don’t benefit from caching on Windows is because we have to cache per working directory and different pipelines run in different working directories.
There was a problem hiding this comment.
Added comments on the ci/build-windows.yml side; I think it makes more sense to have the comments near the decision logic.
Caching doesn't seem to work very well here. On a release, we build an old commit, which has already been tested twice (once as a commit on `main`, once as part of the release PR). CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
skip-windows-tests-on-release
branch
from
78568ce to
82e06a8
Compare
azure-pipelines bot
pushed a commit
that referenced
this pull request
May 19, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @SamirTalwar-DA is in charge of this release. Commit log: ``` a6c7b86 LF: Drop support of TO_QUOTED_TEXT_PARTY (#9721) 9d23b43 Split DA.Internal.Exception.Types into three packages. (#9709) 66d039e Upgrade gatling to version 3.5.1 (#9714) ac9b8ad TODO Cleanup: store.backend package (#9693) 679ce3b LF: Release LF 1.13 (#9705) 73c4793 update NOTICES file (#9711) f249eec drop per-commit compatibility_macos (#9730) 55c36cc Compiler: drop BEToTextBigNumeric in favor of BEToText (#9728) 2a2c745 Implement name collision check for type synonyms. (#9723) c7cc1bf KVL-914 Add more unit tests for tracing (#9708) e63e0cf Upgrade canton to 0.24.0 (#9722) 0a1d00d Canonicalize junit output path (#9710) d4fca03 LF: Change error exception for Arithmetic builtins (#9692) 1e56640 Release: Switch Andreas and me around in the release rotation. (#9719) e50885c Dpp 388 todo cleanup parallel indexer (#9690) fc745f2 LF: clean shifting BigNumeric builtin (#9704) 7a97d88 DA.BigNumeric: Split shift, add roundToNumeric. (#9702) b1738c7 Switch Scala default to 2.13 (#9699) 1edb110 Fix simplifier safety for AnyExceptionMessage (#9707) 0ab37b3 Use new exception builtins in stdlib. (#9703) 7d472e1 Optimistically increase Patience for fixing flakiness in MutableCacheBackedContractStoreSpec (#9697) 69f51e4 speedy: Compile new AnyException primitives (#9700) 3666cf2 KVL-914 Add unit test and fix trace context propagation from config management service (#9694) 4e63299 Simplify kvutils contract keys validation (#9628) 010e2b1 Fix client_server_build/test with port file (#9701) 6d9490c Never create a rollback node containing pre-exception descendants. (#9679) b19c8f2 Drop sanitize, add MagicHash in data-dependencies. (#9698) c669a00 Release SDK 1.13.1 (#9696) 395ff58 Damlification of Bazel files (#9670) 9b53251 Differentiate between negative inputs & errors in contractKeyInputs (#9683) cd99333 runtime: Damlification of Scala files (#9668) fb0551b Fix blackduck flag names (#9695) 4b3b9ef Add race condition tests for exceptions (#9688) 927242b KVL-914 Add and rework unit tests for tracing (#9686) 6568336 Lift constraint tuples up to a type synonym in data-dependencies. (#9687) 80f65b4 LF: clean compilation of SToTextXXX builtins (#9682) ed14f97 Move race condition utilities to test tool infrastructure (#9685) e5646a9 update compat versions for 1.13.1-snapshot.20210512.6834.1.5f532380 (#9681) 6629aab DEL-8479 tag LF libs for SDK 1.13 release (#9680) 55abd0b Add a data-dependencies test for user-defined exceptions (#9659) 142767c Split daml test-script code into a separate library (#9674) d436686 Rerelease 1.13.1 snapshot (#9678) 5d181c6 Throw on internal errors instead of setting ptx to aborted (#9654) ac2e285 Release 1.13.1 snapshot (#9675) af7f88f restore natural join and avoid table aliasing in participant contracts queries (#9671) 625592e Rename CorrelationID to InstanceUUID as it has been used wrongly. (#9672) 638547f rotate release duty after 1.13.0-snapshot.20210511.6892.0.ca9e89b3 (#9648) c282a09 KVL-914 Expose metrics-test-lib for the oem integration kit (#9662) cc01e93 Update error message in interface reader. (#9657) 2dc8b8f Remove version field from rollback node. (#9627) b58d30b skip Windows tests on release (#9656) 40f69ee fix release PR notifications (#9658) 6919153 Fix update metrics population in parallel indexer (#9655) 931274a Drop version check from TransactionPreprocessor (#9651) 4620851 release 1.14.0-snapshot.20210511.6892.0.ca9e89b3 (#9647) 0d09db5 Update date on code owners in RELEASE.md (#9652) e61e6b2 Release SDK 1.13.0 (#9650) 9e6d6f7 Support append-only schema in Sandbox migration tests (#9637) fb9a196 update NOTICES file (#9649) 58d4281 Document web socket event handlers of TS Stream type. (#9634) 111e1d3 Fix sandbox classic package upload (#9633) ``` Changelog: ``` - LF: make LF 1.13 stable Add support for BigNumeric - Ledger API: Bump Ledger API version for LF 1.12 - [Daml Standard Library] `DA.BigNumeric.shift` has been split into `DA.BigNumeric.shiftLeft` and `DA.BigNumeric.shiftRight`. `DA.BigNumeric.roundToNumeric` is introduced, for rounding and converting a BigNumeric to a Numeric in a single move. - [Daml Compiler] Fixed a data-dependencies bug where functions in a data-dependency that used a constraint tuple constraint (e.g. `Template t`) could not be directly invoked. ``` CHANGELOG_BEGIN CHANGELOG_END
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @SamirTalwar-DA is in charge of this release. Commit log: ``` a6c7b86 LF: Drop support of TO_QUOTED_TEXT_PARTY (#9721) 9d23b43 Split DA.Internal.Exception.Types into three packages. (#9709) 66d039e Upgrade gatling to version 3.5.1 (#9714) ac9b8ad TODO Cleanup: store.backend package (#9693) 679ce3b LF: Release LF 1.13 (#9705) 73c4793 update NOTICES file (#9711) f249eec drop per-commit compatibility_macos (#9730) 55c36cc Compiler: drop BEToTextBigNumeric in favor of BEToText (#9728) 2a2c745 Implement name collision check for type synonyms. (#9723) c7cc1bf KVL-914 Add more unit tests for tracing (#9708) e63e0cf Upgrade canton to 0.24.0 (#9722) 0a1d00d Canonicalize junit output path (#9710) d4fca03 LF: Change error exception for Arithmetic builtins (#9692) 1e56640 Release: Switch Andreas and me around in the release rotation. (#9719) e50885c Dpp 388 todo cleanup parallel indexer (#9690) fc745f2 LF: clean shifting BigNumeric builtin (#9704) 7a97d88 DA.BigNumeric: Split shift, add roundToNumeric. (#9702) b1738c7 Switch Scala default to 2.13 (#9699) 1edb110 Fix simplifier safety for AnyExceptionMessage (#9707) 0ab37b3 Use new exception builtins in stdlib. (#9703) 7d472e1 Optimistically increase Patience for fixing flakiness in MutableCacheBackedContractStoreSpec (#9697) 69f51e4 speedy: Compile new AnyException primitives (#9700) 3666cf2 KVL-914 Add unit test and fix trace context propagation from config management service (#9694) 4e63299 Simplify kvutils contract keys validation (#9628) 010e2b1 Fix client_server_build/test with port file (#9701) 6d9490c Never create a rollback node containing pre-exception descendants. (#9679) b19c8f2 Drop sanitize, add MagicHash in data-dependencies. (#9698) c669a00 Release SDK 1.13.1 (#9696) 395ff58 Damlification of Bazel files (#9670) 9b53251 Differentiate between negative inputs & errors in contractKeyInputs (#9683) cd99333 runtime: Damlification of Scala files (#9668) fb0551b Fix blackduck flag names (#9695) 4b3b9ef Add race condition tests for exceptions (#9688) 927242b KVL-914 Add and rework unit tests for tracing (#9686) 6568336 Lift constraint tuples up to a type synonym in data-dependencies. (#9687) 80f65b4 LF: clean compilation of SToTextXXX builtins (#9682) ed14f97 Move race condition utilities to test tool infrastructure (#9685) e5646a9 update compat versions for 1.13.1-snapshot.20210512.6834.1.5f532380 (#9681) 6629aab DEL-8479 tag LF libs for SDK 1.13 release (#9680) 55abd0b Add a data-dependencies test for user-defined exceptions (#9659) 142767c Split daml test-script code into a separate library (#9674) d436686 Rerelease 1.13.1 snapshot (#9678) 5d181c6 Throw on internal errors instead of setting ptx to aborted (#9654) ac2e285 Release 1.13.1 snapshot (#9675) af7f88f restore natural join and avoid table aliasing in participant contracts queries (#9671) 625592e Rename CorrelationID to InstanceUUID as it has been used wrongly. (#9672) 638547f rotate release duty after 1.13.0-snapshot.20210511.6892.0.ca9e89b3 (#9648) c282a09 KVL-914 Expose metrics-test-lib for the oem integration kit (#9662) cc01e93 Update error message in interface reader. (#9657) 2dc8b8f Remove version field from rollback node. (#9627) b58d30b skip Windows tests on release (#9656) 40f69ee fix release PR notifications (#9658) 6919153 Fix update metrics population in parallel indexer (#9655) 931274a Drop version check from TransactionPreprocessor (#9651) 4620851 release 1.14.0-snapshot.20210511.6892.0.ca9e89b3 (#9647) 0d09db5 Update date on code owners in RELEASE.md (#9652) e61e6b2 Release SDK 1.13.0 (#9650) 9e6d6f7 Support append-only schema in Sandbox migration tests (#9637) fb9a196 update NOTICES file (#9649) 58d4281 Document web socket event handlers of TS Stream type. (#9634) 111e1d3 Fix sandbox classic package upload (#9633) ``` Changelog: ``` - LF: make LF 1.13 stable Add support for BigNumeric - Ledger API: Bump Ledger API version for LF 1.12 - [Daml Standard Library] `DA.BigNumeric.shift` has been split into `DA.BigNumeric.shiftLeft` and `DA.BigNumeric.shiftRight`. `DA.BigNumeric.roundToNumeric` is introduced, for rounding and converting a BigNumeric to a Numeric in a single move. - [Daml Compiler] Fixed a data-dependencies bug where functions in a data-dependency that used a constraint tuple constraint (e.g. `Template t`) could not be directly invoked. ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching doesn't seem to work very well here. On a release, we build an old commit, which has already been tested twice (once as a commit on
main, once as part of the release PR).CHANGELOG_BEGIN
CHANGELOG_END