Upgrade rules-nodes to version 3.5.0 #9635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
force-pushed
the
bump-rules-nodejs
branch
2 times, most recently
from
109d74c to
dfe7486
Compare
cocreature
commented
May 11, 2021
| "@npm//websocket-extensions", | ||
| "@npm//wrappy", | ||
| "@npm//xtend", | ||
| "@npm//:node_modules", |
There was a problem hiding this comment.
Visibility seems to have changed in such a way that only direct dependencies are visible. Listing everything in package.json only to then list it here again doesn’t seem very useful so I went for this approach instead.
😭 |
|
Looks like this was introduced by https://github.com/bazelbuild/rules_nodejs/pull/2435/files. |
stefanobaghino-da
approved these changes
May 11, 2021
aherrmann-da
approved these changes
May 11, 2021
No particularly strong reason for doing that. I just like staying up2date. changelog_begin changelog_end
cocreature
force-pushed
the
bump-rules-nodejs
branch
from
dfe7486 to
7d5395c
Compare
cocreature
changed the title
cocreature
force-pushed
the
bump-rules-nodejs
branch
from
44c9083 to
8134c21
Compare
changelog_begin changelog_end
cocreature
force-pushed
the
bump-rules-nodejs
branch
from
8134c21 to
71c2eec
Compare
cocreature
commented
May 25, 2021
|
|
||
| # copy the file; don't use the repository_ctx.template trick with empty substitution as this | ||
| # does not copy over binary files properly | ||
| + cp_args = ["cp", "-f", repository_ctx.path(f), to] if not is_windows_os(repository_ctx) else ["cmd", "/c", "copy /y {} {}".format("\\".join(str(repository_ctx.path(f)).split("/")), "\\".join(to_segments))] |
There was a problem hiding this comment.
@aherrmann-da do you have a better idea for handling this? ctx.file doesn’t work since you either mess up executable bits or break binary files. Just cp doesn’t work because it might not be in PATH and this is a repository rule so we cannot get it from the posix toolchain. Just cmd /c copy does not work because it does not like forward slashes.
So in the end I ended up with this but it seems terrible.
There was a problem hiding this comment.
Unfortunately, I don't really have a better idea. As you describe all these other methods have their respective limitations.
Perhaps string.replace is also a bit less noisy than the split/join, but, I have no strong preference there.
azure-pipelines bot
pushed a commit
that referenced
this pull request
May 26, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @aherrmann-da is in charge of this release. Commit log: ``` 2710fad Normalize rollback nodes when a transaction is constructed (#9712) 646c956 new windows signing (#9786) cae4292 Upgrade rules-nodes to version 3.5.0 (#9635) a336363 ghc-lib: update (#9742) 8ef9361 Scenario: Test ArithemticError (#9757) ad529e9 http-json-perf: querying larger ACSes with different data patterns (#9530) 0b24655 Fix archive calls in ExceptionsIT (#9787) abb7142 Update LF spec for exceptions. (#9784) d208979 Make succ/pred throw an ArithmeticError on overflow. (#9783) cd2ed07 Rename ContractError to PreconditionFailed (#9782) 1b428be Add ledger API test tool tests for rollback projections (#9778) fb6f72c debug signtool on main (#9780) 459de1c update NOTICES file (#9781) 61293c3 maybe fix azuresigntool invocation (#9779) 66b8f19 DPP-406 split append only migration (#9777) 45bca6e test_windows_signing: install for u (#9776) ed36caa Make use of nameOf for naming telemetry traces in participant-integration-api (#9762) 6f20d78 Makes sandbox-classic compression configurable (#9770) b8afa02 test_windows_signing: add quotes (#9773) 4af6608 fix signing machine (#9772) 5717356 fix test_windows_signing job name (#9771) 5855a99 LF: Drop CONTRACT_ERROR (#9754) f5c5b63 prepare for EV Windows signing (#9758) 88c83ec Mark //daml-assistant/daml-helper:test-deployment as flaky (#9769) fa0815b Example export (#9756) 3b33397 update NOTICES file (#9767) 4f97a4d Avoid test log collisions across platforms (#9763) 6f631da Use munit for diffs in ledger-api-test-tool (#9765) 92568eb Make hikari connection pool timeout configurable (#9750) 38cb8b4 Fix flaky CMConcurrentSetConflicting conformance test (#9766) d2bce16 DPP-335 Implement data migration for the append-only schema (#9481) 765d7e3 Throw ContractError in template precondition field (#9760) f5a03b3 Stop leaking Sdk installations from assistant integration tests (#9751) a277560 LF: change format of ArithmeticError message (#9761) 90180eb Make sure we don’t start leaking directories in compat tests (#9759) beb2d13 Add cli option & system property to enable json only logging for http json service (#9725) 3827f82 Fix consumedBy in rollback nodes for scenario service (#9746) 2ba5ca7 Make DA.Assert throw AssertionFailed instead of GeneralError (#9747) b9c36c9 Disable per commit windows compat tests (#9755) b1ca310 ledger: Damlification of Scala files (#9667) 40cf26f Log improvements for parallel indexer (#9752) 3bf6531 ledger-service, navigator: Damlification of Scala files (#9669) f947c02 Extend ConfigManagementServiceIT with tests on generation checking (#9753) f5c84a2 Daml-LF: Damlification of Scala/Haskell files (#9666) 0d931b2 Speedy: implement Arithmetic builtin exceptions (#9653) 5f954da Fix flakiness in hot reload tests (#9748) 40b2381 Compiler: clean convertion builtin name (#9724) 7b1a776 Dpp 384 todo cleanup postgres storage backend (#9727) 2e9bb21 Engine: clean conversion builtin names (#9726) 8efdde6 FutureResourceOwner --> ResourceOwner.forTry (#9720) 1794a6f Refactor GenerateStablePackages (#9744) 14cfe99 update compat versions for 1.14.0-snapshot.20210518.6953.0.a6c7b86a (#9741) 83d60f0 more frequent Windows cache cleanup (#9743) 10177d2 Add golden test for example Daml ledger export (#9732) bb5dd4c Fix locking of envScenarioContexts (#9736) fcbba1c LF: rename convertion builtins to be more obvious (#9716) b55613b Parallelize the data-dependencies test. (#9733) 3209188 Add a ledger model page for exceptions. (#9396) 6245e34 Drop damlc integration test todo (#9735) ae523c7 `ledger-api-bench-tool` - support for multiple streams [DPP-372] (#9691) 0f6f654 rotate release duty after 1.14.0-snapshot.20210518.6953.0.a6c7b86a (#9738) 123e142 release 1.14.0-snapshot.20210518.6953.0.a6c7b86a (#9737) 2dbfe43 Fix conversion of TryContextInfo in scenario service (#9731) e375fef update NOTICES file (#9739) ``` Changelog: ``` [jdbc ledger] increase default hikari connection pool timeout to 2s from 250ms - [Ledger HTTP Json Service] Logging output can now be in JSON either via providing the cli option `--log-encoder json` or via setting the env var `LOG_FORMAT_JSON=true` - [Daml Standard Library] `assert`, `(===)`, and other assertion functions (see DA.Assert) now use a new `CanAssert` typeclass constraint instead of `CanAbort`, in preparation for exceptions support. - [docs] The Daml ledger model has been updated to describe the changes introduced by the new exceptions feature. See here: https://docs.daml.com/concepts/ledger-model/ledger-exceptions.html - [Integration Kit] - Created the ledger-api-bench-tool prototype for benchmarking ledger transaction streaming capabilities - [Integration Kit] - added metrics to the ledger-api-bench-tool - [Integration Kit] - support for multiple streams in the ledger-api-bench-tool ``` CHANGELOG_BEGIN CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No particularly strong reason for doing that. I just like staying up2date.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.