Add runner for non-repudiation #9076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #8633 changelog_begin changelog_end
stefanobaghino-da
force-pushed
the
ste/8633-non-repudiation-runner
branch
from
af4c13a to
9a28901
Compare
cocreature
approved these changes
Mar 11, 2021
...components/non-repudiation-app/src/main/scala/com/daml/nonrepudiation/app/OptionParser.scala
Show resolved
Hide resolved
...components/non-repudiation-app/src/main/scala/com/daml/nonrepudiation/app/OptionParser.scala
Outdated
Show resolved
Hide resolved
...omponents/non-repudiation-app/src/main/scala/com/daml/nonrepudiation/app/Configuration.scala
Show resolved
Hide resolved
I agree. I mostly ran functional tests and have modified versions of Navigator and the JSON API. Once those changes stabilize and are merged we can have meaningful integration tests. |
fwiw I think it’s perfectly fine to ignore Navigator. We only support it as a development tool so supporting non-repudiation is not crucial. |
Makes sense, thanks. |
remyhaemmerle-da
pushed a commit
that referenced
this pull request
Mar 11, 2021
* Add runner for non-repudiation Closes #8633 changelog_begin changelog_end * Fix existing tests * Add test for non-repudiation-app option parser * Remove unnecessary dependencies from non-repudiation testing * Fix Scala 2.13 build errors * Fix help message for --api-address and --api-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8633
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.