Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger API test tool: test against legacy and preview version. #8913

Merged
merged 5 commits into from
Feb 23, 2021

Conversation

remyhaemmerle-da
Copy link
Collaborator

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

],
)
for lf_version in lf_versions_aggregate([
# TODO: uncomment the following line and drop the "legacy" as soon canton-test-runner support LF 1.11 and newers
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @oliverse-da The 2 TODOs in this file are for you.

@remyhaemmerle-da remyhaemmerle-da force-pushed the remy-conformance branch 2 times, most recently from fd7e995 to 4e440dd Compare February 22, 2021 17:39
ledger/ledger-on-memory/BUILD.bazel Outdated Show resolved Hide resolved
ledger/sandbox/BUILD.bazel Outdated Show resolved Hide resolved
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my remarks. 🙇🏻

I think there is one point that requires attention from your latest revision.

ledger/ledger-api-test-tool/conformance.bzl Outdated Show resolved Hide resolved
@remyhaemmerle-da remyhaemmerle-da force-pushed the remy-conformance branch 3 times, most recently from d0fe39d to 1a275c2 Compare February 22, 2021 22:31
@remyhaemmerle-da remyhaemmerle-da force-pushed the remy-conformance branch 2 times, most recently from 0b31935 to c4c69d2 Compare February 22, 2021 22:47
@remyhaemmerle-da remyhaemmerle-da merged commit d17dd7e into main Feb 23, 2021
@remyhaemmerle-da remyhaemmerle-da deleted the remy-conformance branch February 23, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants