-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ledger API test tool: test against legacy and preview version. #8913
Conversation
], | ||
) | ||
for lf_version in lf_versions_aggregate([ | ||
# TODO: uncomment the following line and drop the "legacy" as soon canton-test-runner support LF 1.11 and newers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @oliverse-da The 2 TODOs in this file are for you.
fd7e995
to
4e440dd
Compare
4e440dd
to
b591712
Compare
c1138b6
to
ab3a04e
Compare
CHANGELOG_BEGIN CHANGELOG_END
ab3a04e
to
b849eb5
Compare
b849eb5
to
6c60af6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my remarks. 🙇🏻
I think there is one point that requires attention from your latest revision.
d0fe39d
to
1a275c2
Compare
0b31935
to
c4c69d2
Compare
c4c69d2
to
984fe6b
Compare
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.