tag the docker image build locally #8760
Conversation
CHANGELOG_BEGIN CHANGELOG_END
| @@ -41,4 +41,4 @@ ENV PATH="/home/daml/.daml/bin:${PATH}" | |||
| WORKDIR /home/daml | |||
| EOF | |||
|
|
|||
| docker build ${tmpdir} | |||
| docker build -t "digitalasset/daml-sdk:${version}" ${tmpdir} | |||
There was a problem hiding this comment.
Usually the first segment (before /) in a Docker tag is the repo, so local tags are (by convention) not nested. Perhaps daml-sdk-head:${version} instead?
Also, if we're considering names, it may be worth not tagging them with 0, but instead something like $(git show -s --format=%cd-%h --date=format:%Y%m%d-%H%M%S)? (Only talking about changing the image name here; the build inside Docker should definitely use 0.0.0 otherwise it will take ages.)
There was a problem hiding this comment.
Not sure it makes sense to keep the docker images more persistent than SDK head itself. I think just overwriting is fine and arguably convenient since you get a fixed hash every time.
There was a problem hiding this comment.
Thanks! I agree with @garyverhaegen-da that removing the slash might be less confusing.
| @@ -41,4 +41,4 @@ ENV PATH="/home/daml/.daml/bin:${PATH}" | |||
| WORKDIR /home/daml | |||
| EOF | |||
|
|
|||
| docker build ${tmpdir} | |||
| docker build -t "digitalasset/daml-sdk:${version}" ${tmpdir} | |||
There was a problem hiding this comment.
Not sure it makes sense to keep the docker images more persistent than SDK head itself. I think just overwriting is fine and arguably convenient since you get a fixed hash every time.
|
for reference, the current docker image name makes sense since it matches the one we push to dockerhub making it as easy as possible to swap out a build relying on a released version against one relying on HEAD so let’s keep it. |
This was forgotten in #8745
also add a missing '' in the bash script.
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.