tweak local cache cleanup #8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For various reasons, my attempts at improving the cache cleanup process have been delayed. There are, however, two simple, non-controversial changes I can "backport" without having to wait for consensus on the whole thing: 1. Increase the threshold. At least for the compat jobs, we have seen builds failing after starting with ~32GB free. 2. Kill dangling Bazel processes, which keep some files open and sometimes cause the clean-up process to crash. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
tweak-disk-cleanup
branch
from
35cfd5a to
d382893
Compare
cocreature
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For various reasons, my attempts at improving the cache cleanup process have been delayed. There are, however, two simple, non-controversial changes I can "backport" without having to wait for consensus on the whole thing:
CHANGELOG_BEGIN
CHANGELOG_END