Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger-on-memory: Move committer construction into the writer. [KVL-821] #8735

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 3, 2021

Closer to where it's used.

This looks big but nothing has changed.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Closer to where it's used.

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost requested review from gerolf-da and rautenrieth-da as code owners February 3, 2021 13:12
@ghost ghost requested review from fabiotudone-da and miklos-da February 3, 2021 13:12
@ghost ghost added the automerge label Feb 3, 2021
@mergify mergify bot merged commit 9f06a28 into main Feb 3, 2021
@mergify mergify bot deleted the samir/ledger/ledger-on-memory/writer-owner branch February 3, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants