Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

participant-integration-api: Don't copy the DAR file bytes. #8717

Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2021

This doesn't seem to improve performance much (probably because the real bottleneck is elsewhere), but at the very least it's not necessary.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This doesn't seem to improve performance much (probably because the
real bottleneck is elsewhere), but at the very least it's not necessary.

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost requested review from rautenrieth-da and remyhaemmerle-da February 2, 2021 12:01
@ghost ghost requested a review from gerolf-da as a code owner February 2, 2021 12:01
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@ghost ghost added the automerge label Feb 2, 2021
@mergify mergify bot merged commit c057367 into main Feb 2, 2021
@mergify mergify bot deleted the samir/ledger/participant-integration-api/do-not-copy-dar branch February 2, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants