Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nixpkgs 19.03 #871

Merged
merged 1 commit into from
May 4, 2019
Merged

Upgrade to nixpkgs 19.03 #871

merged 1 commit into from
May 4, 2019

Conversation

cocreature
Copy link
Contributor

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature force-pushed the upgrade-nixpkgs-19.03 branch 2 times, most recently from 2bd5393 to 5d36995 Compare May 3, 2019 07:21
Copy link
Contributor

@neil-da neil-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why draft this?

@cocreature
Copy link
Contributor Author

Mostly because it’s going to take quite a few iterations to get this to actually work so I don’t want to waste anyones time until it goes through CI.

@neil-da
Copy link
Contributor

neil-da commented May 3, 2019

Any chance we can get a document Upgrading.md in the root that describes how to upgrade Nix? I'm going to want a section on Nix, Bazel, Stackage and a few others in there in the fullness of time.

@cocreature
Copy link
Contributor Author

Sure, I’ll add something. But most of the work comes from having to fix issues arising from the update and these vary significantly from upgrade to upgrade so it’s somewhat hard to capture them in a readme.

@neil-da
Copy link
Contributor

neil-da commented May 3, 2019

Yep, mostly we need to know where to start and any issues that recur a lot. I'm only hoping for a paragraph or two.

@cocreature cocreature force-pushed the upgrade-nixpkgs-19.03 branch from 116ee35 to f32caa7 Compare May 4, 2019 10:00
@cocreature cocreature marked this pull request as ready for review May 4, 2019 18:07
@cocreature cocreature force-pushed the upgrade-nixpkgs-19.03 branch from f32caa7 to 1e8ffa5 Compare May 4, 2019 18:09
@mergify mergify bot merged commit 3d8acde into master May 4, 2019
@mergify mergify bot deleted the upgrade-nixpkgs-19.03 branch May 4, 2019 20:01
cocreature added a commit that referenced this pull request May 4, 2019
This reverts commit 3d8acde.

For some reason that commit seems to have resulted in a lot of
"unexpected end of file" errors during cache downloads. I do not know
what is going on here or how to fix it so let’s revert it for now.
mergify bot pushed a commit that referenced this pull request May 5, 2019
This reverts commit 3d8acde.

For some reason that commit seems to have resulted in a lot of
"unexpected end of file" errors during cache downloads. I do not know
what is going on here or how to fix it so let’s revert it for now.
cocreature added a commit that referenced this pull request May 7, 2019
cocreature added a commit that referenced this pull request May 7, 2019
cocreature added a commit that referenced this pull request May 7, 2019
* Upgrade to nixpkgs 19.03 (#871)

* Fix nix-build restart

Without || true we will never get to the next line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants