Bump JVM on Darwin and force TLS 1.2 #8697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
force-pushed
the
debug-macos
branch
from
54c9811 to
c6cc53d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Details are in the comments but this seems to workaround the annoying tls issues we have been dealing with for the past few days. changelog_begin changelog_end
cocreature
force-pushed
the
debug-macos
branch
from
70c472a to
4537436
Compare
cocreature
commented
Feb 1, 2021
| @@ -8,6 +8,20 @@ let | |||
|
|
|||
| # package overrides | |||
| overrides = _: pkgs: rec { | |||
| # nixpkgs ships with a very old version of openjdk on darwin | |||
There was a problem hiding this comment.
I don’t think this is actually required but the fact that we are on a pretty old JDK doesn’t inspire confidence and I’d rather not waste time debugging issues that have already been fixed.
| @@ -27,7 +41,7 @@ let | |||
| # and/or documentation. | |||
| (pkgs.fetchurl { | |||
| url = "https://patch-diff.githubusercontent.com/raw/bazelbuild/bazel/pull/8983.patch"; | |||
| sha256 = "1j25bycn9q7536ab3ln6yi6zpzv2b25fwdyxbgnalkpl2dz9idb7"; | |||
| sha256 = "1qdyqymsylinkdwqhbxbm8bvbyznrdn74n744pi5xhdwb6lw1r8a"; | |||
There was a problem hiding this comment.
this is unrelated, changing the JVM forced a rebuild and needed a hash change because this file has changed upstream. There don’t seem to be any relevant changes and the PR has now been closed (looks like the change has made it into Bazel 4.0) so hopefully it will stay stable until we get to Bazel 4.0 and can drop it.
stefanobaghino-da
approved these changes
Feb 1, 2021
aherrmann-da
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the comments but this seems to workaround the annoying
tls issues we have been dealing with for the past few days.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.