ledger-api-test-tool: Provide context when expecting a failing Future. #8690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `Future#failed` a _lot_ in the conformance tests. Usually, this works fine, but it has the unfortunate effect of yielding a useless error message when the future was actually a success: ``` Future.failed not completed with a throwable. ``` Combined with the lack of useful stack traces, because futures, this makes the test failure completely useless. This changes all calls of `Future#failed` in our conformance tests to use a new extension method, `#mustFail`, which takes a mandatory "context" parameter to provide context, and includes both the context and the value in the future in case of success. CHANGELOG_BEGIN CHANGELOG_END
ghost
requested review from
fabiotudone-da
approved these changes
Jan 29, 2021
ghost
added
the
mergify
bot
deleted the
samir/ledger/ledger-api-test-tool/better-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
Future#faileda lot in the conformance tests. Usually, this works fine, but it has the unfortunate effect of yielding a useless error message when the future was actually a success:Combined with the lack of useful stack traces, because futures, this makes the test failure completely useless.
This changes all calls of
Future#failedin our conformance tests to use a new extension method,#mustFail, which takes a mandatory "context" parameter to provide context, and includes both the context and the value in the future in case of success.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.