Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased compatibility test size for *classic-postgresql to 'large' [DPP-195] #8666

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Increased compatibility test size for *classic-postgresql to 'large' [DPP-195] #8666

merged 1 commit into from
Feb 1, 2021

Conversation

kamil-da
Copy link
Contributor

This change is our current best guess on a fix (an experiment really) to get rid of timeouts in *-classic-postgresql conformance tests.
Change is done according to the Bazel docs.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

cocreature
cocreature reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned yesterday, I don’t think this does anything. The size only affects scheduling according to @aherrmann-da and this is an exclusive test so it cannot be scheduled any more exclusive than it already is.

@kamil-da
Copy link
Contributor Author

As mentioned yesterday, I don’t think this does anything. The size only affects scheduling according to @aherrmann-da and this is an exclusive test so it cannot be scheduled any more exclusive than it already is.

I've done local testing with this change and it didn't make much difference which could confirm what you say.
But the team's opinion on this was "let's give it a try", hence the PR.

@kamil-da kamil-da requested a review from mziolekda January 28, 2021 14:30
@cocreature
Copy link
Contributor

not opposed to merging it, it shouldn’t do any harm either.

mziolekda
mziolekda approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@mziolekda mziolekda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in. There is a theory that large size might boost bazel resource allocation. If true it would help fix flay compatibility tests.

@mziolekda mziolekda merged commit 7cf1914 into main Feb 1, 2021
@mziolekda mziolekda deleted the kamil-da/increase-size-of-conformance-tests branch February 1, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature left review comments

@mziolekda mziolekda mziolekda approved these changes

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamil-da @cocreature @mziolekda