fix perf_speedy report #8655
Merged
fix perf_speedy report #8655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
reviewed
Jan 27, 2021
ci/cron/daily-compat.yml
Outdated
| @@ -23,53 +23,6 @@ schedules: | |||
| always: true | |||
|
|
|||
| jobs: | |||
| - job: compatibility_ts_libs | |||
There was a problem hiding this comment.
I’m confused, why is there so much deleted stuff?
There was a problem hiding this comment.
Second commit will be dropped before merging; only the first one needs review. Sorry, should have mentioned that.
There was a problem hiding this comment.
Well actually, that failed, so hold off on reviewing.
garyverhaegen-da
force-pushed
the
fix-perf-report
branch
from
9521553 to
eed589b
Compare
The report currently chokes on quotes in the commit message (see 550aa48). Rather than trying to correctly excape things in Bash, this PR delegates the quote handling to jq, because having to deal with Bash embedded in YAML is hard enough. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
fix-perf-report
branch
from
eed589b to
90028bb
Compare
|
Oh, forgot to update: this is now fully working and thus ready for review. You can see there's a quote in the commit title and the compat tests (and thus the perf) have run successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report currently chokes on quotes in the commit message (see 550aa48). Rather than trying to correctly excape things in Bash, this PR delegates the quote handling to jq, because having to deal with Bash embedded in YAML is hard enough.
CHANGELOG_BEGIN
CHANGELOG_END