Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set LOCAL_ARCHIVE when unset #8627

Merged
1 commit merged into from
Jan 26, 2021
Merged

fix: set LOCAL_ARCHIVE when unset #8627

1 commit merged into from
Jan 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2021

Fixes #8573.
Fixes #8574.

We set the LOCA_ARCHIVE environment variable when a locales archive
exists and the variable is unset.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@ghost ghost requested a review from cocreature January 26, 2021 11:18
Fixes #8573.
Fixes #8574.

We set the LOCA_ARCHIVE environment variable when a locales archive
exists and the variable is unset.

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost force-pushed the package_local_archive branch from 04bf2ff to 6dabd89 Compare January 26, 2021 12:22
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Confirmed that this works as expected for me

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now with the correct button

@ghost ghost merged commit fdbe6cc into main Jan 26, 2021
@ghost ghost deleted the package_local_archive branch January 26, 2021 14:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repl crashes for non-English characters Repl terminal changes unicode chars input to "??"
1 participant