participant-integration-api: Reuse the services execution context for data munging. #8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Pull request contains merge conflicts. |
ghost
force-pushed
the
samir/ledger/participant-integration-api/shared-services-execution-context
branch
from
6b0a7ef to
09c0408
Compare
|
In testing on proprietary code, this seems to get about a 5% performance improvement, which I'm putting down to less CPU contention. |
ghost
marked this pull request as ready for review
ghost
self-requested a review
ghost
requested review from
dasormeter,
fabiotudone-da,
gerolf-da,
miklos-da,
mziolekda and
rautenrieth-da
as code owners
tudor-da
approved these changes
Jan 21, 2021
matthiasS-da
approved these changes
Jan 21, 2021
Rather than spawning a separate thread pool for manipulating data before and after index queries, we can just re-use the services EC, which is already a work-stealing thread pool.
CHANGELOG_BEGIN CHANGELOG_END
mziolekda
force-pushed
the
samir/ledger/participant-integration-api/shared-services-execution-context
branch
from
09c0408 to
cddfea7
Compare
mziolekda
reviewed
Jan 29, 2021
ledger/participant-integration-api/src/main/scala/platform/indexer/JdbcIndexer.scala
Show resolved
Hide resolved
ghost
added
the
mergify
bot
deleted the
samir/ledger/participant-integration-api/shared-services-execution-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the obvious follow-up to #7945. We can share the work-stealing execution pool between the indexer and the API server when they run in the same process.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.