LF : Fix/Clean some LF related TODOs #8387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
dasormeter,
fabiotudone-da,
gerolf-da,
miklos-da,
mziolekda and
S11001001
as code owners
remyhaemmerle-da
force-pushed
the
remy-lf-todos
branch
from
3f17232 to
fbca282
Compare
navigator/backend/src/main/scala/com/digitalasset/navigator/query/project/package.scala
Show resolved
Hide resolved
cocreature
reviewed
Jan 5, 2021
...f/transaction/src/test/scala/com/digitalasset/daml/lf/transaction/TransactionCoderSpec.scala
Outdated
Show resolved
Hide resolved
hurryabit
reviewed
Jan 6, 2021
There was a problem hiding this comment.
Except for the navigator test, which I can't really judge, this looks good to me. If @stefanobaghino-da and @rautenrieth-da are happy with the changes there, let's merge. Thank you.
| def twoDifferentVersions = | ||
| for { | ||
| v1 <- Gen.oneOf(postV10versions) | ||
| v2 <- Gen.oneOf(postV10versions.filter(_ != v1)) |
There was a problem hiding this comment.
How about
Suggested change
| v2 <- Gen.oneOf(postV10versions.filter(_ != v1)) | |
| v2 <- Gen.oneOf(postV10versions.filter(_ > v1)) |
and remove the call to inIncreasingOrder below? This seems to express the intent more clearly.
There was a problem hiding this comment.
Good idea.
| # FixMe: https://github.com/digital-asset/daml/issues/2289 | ||
| # change version to lf_latest_version when freezing numeric in the next language version | ||
| target = lf_dev_version, | ||
| target = lf_latest_version, |
There was a problem hiding this comment.
Numeric is already in DAML-LF 1.8, isn't it? So, I guess we just missed this.
hurryabit
approved these changes
Jan 6, 2021
remyhaemmerle-da
force-pushed
the
remy-lf-todos
branch
from
b436a1c to
8236718
Compare
rautenrieth-da
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.