Build //libs-scala/... on 2.13 #8282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test is unfortunately disabled at the moment since I utterly failed to figure out why I get a ClassNotFoundException on 2.13. changelog_begin changelog_end
cocreature
requested review from
garyverhaegen-da,
gerolf-da,
rautenrieth-da and
stefanobaghino-da
as code owners
cocreature
commented
Dec 14, 2020
| @@ -42,6 +42,7 @@ version_specific = { | |||
| "-Xlint:unsound-match", | |||
| "-Xlint:by-name-right-associative", # will never be by-name if used correctly | |||
| "-Xfuture", | |||
| "-language:higherKinds", | |||
There was a problem hiding this comment.
The alternative is to silence unused imports on 2.13 either selectively or completely. This seemed nicer but open to changing it.
cocreature
commented
Dec 14, 2020
| @@ -101,12 +98,12 @@ final class ResourceFactories[Context: HasExecutionContext] { | |||
| * @tparam U The return type. | |||
| * @return A [[Resource]] with a sequence of the values of the sequenced [[Resource]]s as its underlying value. | |||
| */ | |||
| def sequence[T, C[X] <: Traversable[X], U](seq: C[R[T]])( | |||
There was a problem hiding this comment.
@S11001001 @SamirTalwar-DA My CanBuildFrom foo is very weak so please review this closely.
There was a problem hiding this comment.
It looks fine for me, and the tests should fail if it's wrong. I can't say for sure though because I haven't used 2.13's Factory.
changelog_begin changelog_end
changelog_begin changelog_end
cocreature
force-pushed
the
libs-scala-2.13
branch
from
2dac432 to
eaca75c
Compare
cocreature
requested review from
dasormeter,
fabiotudone-da,
miklos-da and
mziolekda
as code owners
ghost
reviewed
Dec 14, 2020
...i/rs-grpc-akka/src/main/scala/com/digitalasset/grpc/adapter/AkkaExecutionSequencerPool.scala
Outdated
Show resolved
Hide resolved
...xtualized-logging/src/test/suite/scala/com/digitalasset/logging/ContextualizedLoggerIT.scala
Show resolved
Hide resolved
| @@ -101,12 +98,12 @@ final class ResourceFactories[Context: HasExecutionContext] { | |||
| * @tparam U The return type. | |||
| * @return A [[Resource]] with a sequence of the values of the sequenced [[Resource]]s as its underlying value. | |||
| */ | |||
| def sequence[T, C[X] <: Traversable[X], U](seq: C[R[T]])( | |||
There was a problem hiding this comment.
It looks fine for me, and the tests should fail if it's wrong. I can't say for sure though because I haven't used 2.13's Factory.
|
|
||
| override def run(): Unit = { | ||
| p.tryCompleteWith { | ||
| p.completeWith { |
There was a problem hiding this comment.
OK, clearly this API was already broken, but I'm surprised they deprecated tryCompleteWith and not this one, as the semantics are far closer to trySuccess and tryFailure.
S11001001
reviewed
Dec 14, 2020
libs-scala/resources/src/main/2.13/com/daml/resources/UnitCanBuildFrom.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Samir Talwar <samir.talwar@digitalasset.com>
S11001001
approved these changes
Dec 14, 2020
…uildFrom.scala Co-authored-by: Stephen Compall <stephen.compall@daml.com>
changelog_begin changelog_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test is unfortunately disabled at the moment since I utterly
failed to figure out why I get a ClassNotFoundException on 2.13.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.