Separate auth API from implementation and testing code #8183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out the API types `Request`/`Response` into their own Bazel targets, so that the trigger service does not have to depend on the full middleware and OAuth2 test server targets. Also rename packages: Generic auth code goes into `com.daml.auth`, OAuth2 specific code goes into `com.daml.auth.oauth2` or `com.daml.auth.middleware.oauth2`. changelog_begin changelog_end
This is a left-over from #7226.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factors out API definitions into separate Bazel targets so that the middleware does not need to depend on the OAuth2 test server and the trigger service does not need to depend on the middleware implementation.
Renames packages so that generic auth code sits under
com.daml.authand OAuth2 specific code lives underoauth2namespaces.Removes
//triggers/service:auth-client-testswhich was a left-over from #7226.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.