Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Navigator from TSLint to ESLint #8172

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Conversation

cocreature
Copy link
Contributor

TSLint is deprecated and not depending on things written by Palantir makes me happy, so this PR switches Navigator over.

Unfortunately, the diff is pretty messy. I’ve split it into 3 PRs:

  1. Swapping out the config files and adapting the Bazel config.
  2. Renaming the comments to disable the lints on a bunch of lines.
  3. Addressing the actual new hints.

I strongly recommend reviewing this with whitespace disabled since eslint warns on non-breaking spaces by default and for whatever reason we had tons of those.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

changelog_begin
changelog_end
changelog_begin
changelog_end
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changelog_begin
changelog_end
@cocreature cocreature merged commit 8d6f1c9 into master Dec 4, 2020
@cocreature cocreature deleted the navigator-eslint branch December 4, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants