ledger-api: Use proto_jars, and publish Protobuf sources separately from the Scala classes. [KVL-714]
#8091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG_BEGIN - [Ledger API] The Scala JARs containing the gRPC definitions no longer contain the *.proto files used to generate the ScalaPB-based classes. CHANGELOG_END
CHANGELOG_BEGIN - [Ledger API] The *.proto files containing the gRPC definitions are now provided by a new Maven Central artifact, with the group "com.daml" and the artifact name "ledger-api-proto". CHANGELOG_END
ghost
self-requested a review
ghost
requested review from
dasormeter,
fabiotudone-da,
gerolf-da,
miklos-da,
mziolekda,
rautenrieth-da,
S11001001 and
stefanobaghino-da
as code owners
cocreature
approved these changes
Nov 27, 2020
| visibility = ["//visibility:public"], | ||
| ) if is_windows == False else None | ||
|
|
||
| if maven_group and maven_artifact_prefix: |
There was a problem hiding this comment.
Can we always generate this or does this fail if this is not set? The logic is complex enough so if we can make less things conditional, it seems a bit simpler.
There was a problem hiding this comment.
No, because the target doesn't have Maven coordinates.
| @@ -45,7 +45,7 @@ load("@rules_pkg//:pkg.bzl", "pkg_tar") | |||
| ], | |||
| maven_artifact_prefix = "daml-lf-%s-archive" % version, | |||
| maven_group = "com.daml", | |||
| strip_import_prefix = "src/main/protobuf/", | |||
| strip_import_prefix = "src/main/protobuf", | |||
There was a problem hiding this comment.
What changed to require this? Was it broken before?
There was a problem hiding this comment.
It has exactly the same behavior, but this makes it more consistent with other usages of the same parameter.
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior is to bundle the Protobuf definitions in both the generated Scala JAR and its source JAR. This makes it hard to pull these in and generate the Scala code yourself, because you have to get both the source and the generated code, which means generating your own will lead to classpath conflicts, with multiple versions of the same gRPC classes.
If you were generating Java (or Kotlin, or Clojure, or…) gPRC classes, this wouldn't be a problem, but you would have Scala classes on your classpath for no reason.
Changelog
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.