Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get lsof from dev-env #8064

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Get lsof from dev-env #8064

merged 1 commit into from
Nov 25, 2020

Conversation

cocreature
Copy link
Contributor

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature force-pushed the macos-lsof branch 3 times, most recently from 952d41e to 76b144d Compare November 25, 2020 14:05
@cocreature
Get lsof from dev-env
ecfccc1 
On MacOS we don’t seem to have lsof by default which disables our
sandbox cleanup for stray instances.

changelog_begin
changelog_end
@cocreature cocreature changed the title debug lsof Get lsof from dev-env Nov 25, 2020
@cocreature cocreature requested review from garyverhaegen-da and a user November 25, 2020 14:17
@cocreature cocreature marked this pull request as ready for review November 25, 2020 14:17
ghost
ghost approved these changes Nov 25, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't see an error message any more, so I guess we're good to go!

@mergify mergify bot merged commit 4e39e61 into master Nov 25, 2020
@mergify mergify bot deleted the macos-lsof branch November 25, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cocreature