-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check trigger dao migrations digests #7908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann-da
requested review from
gerolf-da,
hurryabit and
rautenrieth-da
as code owners
November 5, 2020 15:10
aherrmann-da
commented
Nov 5, 2020
.locations(s"classpath:/$migrationsResourcePath") | ||
val resourceScanner = flywayScanner(configuration) | ||
val resources = resourceScanner.getResources("", ".sql").asScala.toSeq | ||
resources.size should be >= 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the purpose of the >=
check here but have kept it alive in the refactored version. cc @SamirTalwar-DA
cocreature
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, thanks!
Addressing review comment
garyverhaegen-da
pushed a commit
that referenced
this pull request
Nov 6, 2020
* Check the trigger dao migrations digest Following the example of the corresponding ledger on SQL tests. The digests had to be updated as both of them had gone out of sync. The init digest presumably due to the change in #7226 and the one for adding the access token during review of #7890. changelog_begin changelog_end * define abstract migrations test * Use abstract migrations test in trigger service tests * use abstract migrations test in ledger on SQL * Retain check for number of .sql resources * Factor out the hash-migrations script * Consistent shell settings Addressing review comment Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7900
hash-migration.sh
script as wellThe init digest presumably due to the change in Remove ref-ledger-authenticator from trigger service #7226 and the one for adding the access token during review of Store access token in trigger dao #7890.
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.