work around Azure/GitHub disagreement #7790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you suggesting to change the required check to this? Otherwise, I don’t understand how this helps. |
garyverhaegen-da
force-pushed
the
final-job
branch
from
981a41a to
0fbe98f
Compare
Yes, that's what I meant by "which GitHub could depend on". |
|
But I'm a bit concerned Azure will go "oh, one of the dependencies has been skipped, so let me skip this too". |
cocreature
approved these changes
Oct 23, 2020
garyverhaegen-da
force-pushed
the
final-job
branch
2 times, most recently
from
5654b88 to
cba52e5
Compare
|
Amended with condition |
Azure used to report the status of the entire build to GitHub, which we use as the "required check" for PRs to be merged. Ir doesn't do that anymore which means we can't merge anything. It's unclear whether or not that is a deliberate change. This attempts to work around that by creating an extra job that depends on all the other, which GitHub could depend on. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
final-job
branch
from
cba52e5 to
57a2333
Compare
garyverhaegen-da
added a commit
that referenced
this pull request
Nov 4, 2020
It looks like Azure is correctly reporting the overall job completion again. See #7790 for details. CHANGELOG_BEGIN CHANGELOG_END
Merged
garyverhaegen-da
added a commit
that referenced
this pull request
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure used to report the status of the entire build to GitHub, which we use as the "required check" for PRs to be merged. Ir doesn't do that anymore which means we can't merge anything. It's unclear whether or not that is a deliberate change.
This attempts to work around that by creating an extra job that depends on all the other, which GitHub could depend on.
Note: I am not sure how (if) this will work with skipped jobs.
CHANGELOG_BEGIN
CHANGELOG_END