Authorize on trigger service stop endpoint #7750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog_begin changelog_end
aherrmann-da
commented
Oct 20, 2020
Comment on lines
+197
to
+198
| override def getRunningTrigger(triggerInstance: UUID): Either[String, Option[RunningTrigger]] = | ||
| run(queryRunningTrigger(triggerInstance)) |
There was a problem hiding this comment.
Note, this part is not tested, yet. This depends on #7720.
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds authorization to the stop endpoint of the trigger service, if authorization via the auth middleware is enabled.
Stopping the trigger will require the same claims as starting the trigger, i.e.
actAsthe trigger party. In order to determine the trigger party we first need to query for the running trigger before we can authorize the request.Part of #7723
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.