Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sed script to help with updating the damlc ITs #7727

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add sed script to help with updating the damlc ITs #7727

merged 1 commit into from
Oct 19, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Oct 16, 2020 •
edited
Loading

Updating the expected dignostics for damlc's integration tests can
be quite tedious. This PR adds a sed script to simplify it a bit.
See the included readme for details.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

@hurryabit
Add sed script to help with updating the damlc ITs
59e1631 
Updating the expected dignostics for `damlc`'s integration tests can
be quite tedious. This PR adds a `sed` script to simplify it a bit.
See the included readme for details.

CHANGELOG_BEGIN
CHANGELOG_END
@hurryabit hurryabit requested a review from cocreature as a code owner October 16, 2020 18:37
@hurryabit
Copy link
Contributor Author

FYI @sofiafaro-da @remyhaemmerle-da @Robin-da @nickchapman-da

sofiafaro-da
sofiafaro-da approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@sofiafaro-da sofiafaro-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@hurryabit hurryabit merged commit 5f0acbc into master Oct 19, 2020
@hurryabit hurryabit deleted the damlc-intergration-sedness branch October 19, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofiafaro-da sofiafaro-da sofiafaro-da approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

@cocreature cocreature Awaiting requested review from cocreature

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hurryabit @sofiafaro-da