Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional dependency support in data-dependencies #7719

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

sofiafaro-da
Copy link
Contributor

@sofiafaro-da sofiafaro-da commented Oct 16, 2020

This PR adds support for functional dependencies in data-dependencies.
It also adds a small test to make sure these are imported.

changelog_begin

  • [DAML Compiler] Functional dependencies are now saved
    by the DAML compiler in the DALF file / DAR package. When
    importing a file with the functional dependency data via
    data-dependencies, these will be picked up automatically.

changelog_end

changelog_begin

- [DAML Compiler] Functional dependencies are now saved
  by the DAML compiler in the DALF file / DAR package. When
  importing a file with the functional dependency data via
  data-dependencies, these will be picked up automatically.

changelog_end
@sofiafaro-da sofiafaro-da marked this pull request as ready for review October 19, 2020 10:59
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you so much!

@sofiafaro-da sofiafaro-da merged commit 8e4e0f9 into master Oct 19, 2020
@sofiafaro-da sofiafaro-da deleted the data-deps branch October 19, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants