Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positioning the 'Next' buttonn so it doesn't overlap with other elements #7716

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

nemanja-da
Copy link
Contributor

This was by far the easiest and nicest solution I could come up with. The problem is that often the "Next" button in the docs would overlap with the "Feedback" button or would fall under the "In this section" content navigation.

image

image

with the new placement it looks like this

image

image

I've tried first leaving the button where it is, but the combo of responsive placement that needed to be done wasn't really optimal.

CHANGELOG_BEGIN
CHANGELOG_END

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, thanks!

You are missing an (empty) changelog entry to make CI happy.

CHANGELOG_END
@nemanja-da nemanja-da merged commit 6a452c1 into master Oct 16, 2020
@nemanja-da nemanja-da deleted the next_button_overlap_fix branch October 16, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants