Relax SQL exception constraints in ReadOnlySqlLedger #7675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-da
force-pushed
the
relax-retry-predicate-jdbc-exceptions
branch
from
af4af7d to
c7d03c9
Compare
rautenrieth-da
approved these changes
Oct 13, 2020
tudor-da
force-pushed
the
relax-retry-predicate-jdbc-exceptions
branch
from
c7d03c9 to
5bff05d
Compare
changelog_begin changelog_end
tudor-da
force-pushed
the
relax-retry-predicate-jdbc-exceptions
branch
from
5bff05d to
b979abd
Compare
tudor-da
changed the title
fabiotudone-da
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
On second thought, can you double-check HikariJdbcConnectionProvider.scala?
Also, I think some unit tests are failing https://dev.azure.com/digitalasset/daml/_build/results?buildId=57951&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=f58be928-45a1-58e7-c1ad-04869565b3f4&l=4481
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
It seems that the failure is occasional and not related (a ticket is already open for this #7521) |
ghost
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax SQL exception constraints in
ReadOnlySqlLedgerThis was motivated by the fact that PostgreSQL errors do not inherit from
java.sql.SQLNonTransientException. We do not want to rely on database implementations throwing specific errors.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.