add silent_annotations option to da_scala bazel functions #7668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S11001001
requested review from
dasormeter,
fabiotudone-da,
gerolf-da,
hurryabit,
miklos-da,
mziolekda,
rautenrieth-da and
remyhaemmerle-da
as code owners
CHANGELOG_BEGIN CHANGELOG_END
cocreature
approved these changes
Oct 13, 2020
| name = "", | ||
| scalacopts = [], | ||
| plugins = [], | ||
| generated_srcs = [], # hiding from the underlying rule |
There was a problem hiding this comment.
My hiding you mean we don’t pass it along? Do you know why we even have this field then?
There was a problem hiding this comment.
It's there to make sure it doesn't end up in kwargs.
ghost
approved these changes
Oct 13, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #6907 it became obvious that a simpler way to declare that a build rule wished to enable
@silentwould be very nice, but that PR was already quite large enough. #7661's effective requirement of sed-based build file editing clarified that we should resolve this boilerplate.So here it is: add
silent_annotations = Trueto your Scala build if you want access to the@silentannotation, delete it if you don't need it anymore.As a (desired) side effect of abstracting this, every use of silencer also acquires the
checkUnusedoption in this PR to ensure that we clean up stray@silents.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.