LF: enforce non-empty maintainers in contract key in fetchByKey #7649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
aherrmann-da and
cocreature
as code owners
remyhaemmerle-da
force-pushed
the
remy-lf-key-with-maintainers
branch
from
a025536 to
63508cf
Compare
remyhaemmerle-da
changed the title
remyhaemmerle-da
force-pushed
the
remy-lf-key-with-maintainers
branch
2 times, most recently
from
2d50dc2 to
96b51e0
Compare
daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/EngineTest.scala
Show resolved
Hide resolved
daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/EngineTest.scala
Show resolved
Hide resolved
andreaslochbihler-da
approved these changes
Oct 12, 2020
This fixes a bug in the Speedy interpreter. With this change, the interpreter crashes if it attempts to fetch using a contract key that has an empty set of maintainers. This propagates to exerciseByKey as this command is compiled using fetchByKey speedy builtin. This is a breaking change approved by @bame-da . CHANGELOG_BEGIN [LF] (Bug fix) enforce non-empty maintainers in contract key during exericiseByKey. CHANGELOG_END
remyhaemmerle-da
force-pushed
the
remy-lf-key-with-maintainers
branch
from
0371320 to
38bc3df
Compare
hurryabit
approved these changes
Oct 14, 2020
compiler/damlc/tests/daml-test-files/EmptyContractKeyMaintainers.daml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the Speedy interpreter. With this change, the
interpreter crashes if it attempts to exercise a choice using a
contract key that has an empty set of maintainers.
This is a breaking change approved by @bame-da .
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.