Fix broken migration #7643
Merged
Fix broken migration #7643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing version of the migration replaced null values with empty arrays. The presence of null values is used by the queries to discriminate create and exercise events. This caused an illegal state exception when reading active contracts for the API (which are represented by their create events on the events table) as the reader was mistakenly reading exercise events and create events. changelog_begin changelog_end
stefanobaghino-da
requested review from
gerolf-da and
rautenrieth-da
as code owners
stefanobaghino-da
requested review from
a user,
cocreature and
garyverhaegen-da
gerolf-da
approved these changes
Oct 12, 2020
ghost
reviewed
Oct 12, 2020
...cipant-integration-api/src/main/scala/db/migration/postgres/V38__Update_value_versions.scala
Show resolved
Hide resolved
@SamirTalwar-DA Manual testing with in-house application. Inspected the database, ensured that functionality of the app. This error condition only pops up when using "very old" pre-1.0 ledgers and the compatibility tests cannot cover this, unfortunately. |
|
Sounds good, thanks! |
cocreature
pushed a commit
that referenced
this pull request
Oct 12, 2020
The existing version of the migration replaced null values with empty arrays. The presence of null values is used by the queries to discriminate create and exercise events. This caused an illegal state exception when reading active contracts for the API (which are represented by their create events on the events table) as the reader was mistakenly reading exercise events and create events. changelog_begin changelog_end
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2020
The existing version of the migration replaced null values with empty arrays. The presence of null values is used by the queries to discriminate create and exercise events. This caused an illegal state exception when reading active contracts for the API (which are represented by their create events on the events table) as the reader was mistakenly reading exercise events and create events. changelog_begin changelog_end Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing version of the migration replaced null values with
empty arrays. The presence of null values is used by the queries
to discriminate create and exercise events. This caused an
illegal state exception when reading active contracts for the API
(which are represented by their create events on the events table)
as the reader was mistakenly reading exercise events and create
events.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.