Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LF: decouple template from record in the Scala Ast. #7631

Merged
merged 1 commit into from
Oct 12, 2020
Merged

LF: decouple template from record in the Scala Ast. #7631

merged 1 commit into from
Oct 12, 2020

Conversation

remyhaemmerle-da
Copy link
Collaborator

CAHNGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da added the component/daml-engine DAML-LF Engine & Interpreter label Oct 9, 2020
@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Oct 9, 2020
@remyhaemmerle-da remyhaemmerle-da requested a review from a user October 9, 2020 15:32
@remyhaemmerle-da remyhaemmerle-da requested a review from a user October 9, 2020 15:32
@remyhaemmerle-da remyhaemmerle-da force-pushed the remy-lf-template-definitions branch from 43ae6f7 to 2210b58 Compare October 9, 2020 15:34
@remyhaemmerle-da remyhaemmerle-da force-pushed the remy-lf-template-definitions branch from 2210b58 to dca929a Compare October 9, 2020 15:36
hurryabit
hurryabit approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better. Thanks a lot!

@remyhaemmerle-da
Copy link
Collaborator Author

This was surprisingly easy.

@remyhaemmerle-da remyhaemmerle-da merged commit ea2a637 into master Oct 12, 2020
@remyhaemmerle-da remyhaemmerle-da deleted the remy-lf-template-definitions branch October 12, 2020 09:28
@remyhaemmerle-da remyhaemmerle-da mentioned this pull request Oct 12, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

@cocreature cocreature Awaiting requested review from cocreature

@dasormeter dasormeter Awaiting requested review from dasormeter

@fabiotudone-da fabiotudone-da Awaiting requested review from fabiotudone-da

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

@miklos-da miklos-da Awaiting requested review from miklos-da

@mziolekda mziolekda Awaiting requested review from mziolekda

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

Assignees
No one assigned
Labels
component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Milestone
Maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@remyhaemmerle-da @hurryabit