Add timer to track queue delay in InstrumentedSource.queue #7601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
bame-da,
gerolf-da,
hurryabit,
nemanja-da and
rautenrieth-da
as code owners
ghost
self-requested a review
and use it from TrackerImpl. CHANGELOG_BEGIN CHANGELOG_END
ghost
force-pushed
the
jussi/queue-delay-metric
branch
from
a9b4767 to
ce2fab6
Compare
ghost
approved these changes
Oct 8, 2020
ledger/metrics/src/test/scala/com/daml/metrics/InstrumentedSourceSpec.scala
Outdated
Show resolved
Hide resolved
Comment on lines
66
to
70
| .map { x => | ||
| // Sleep to delay the processing of the next element. | ||
| Thread.sleep(5) | ||
| x | ||
| } |
There was a problem hiding this comment.
Perhaps use the scheduler here rather than blocking a Future thread?
Suggested change
| .map { x => | |
| // Sleep to delay the processing of the next element. | |
| Thread.sleep(5) | |
| x | |
| } | |
| .mapAsync(1) { x => | |
| scheduler.scheduleOnce(5.seconds)(Future(x)) | |
| } |
There was a problem hiding this comment.
Thanks, good suggestion. I'll give it a try. (It's 5 millis though).
There was a problem hiding this comment.
scheduler didn't have the right methods, but found this instead: https://doc.akka.io/docs/akka/current/futures.html.
There was a problem hiding this comment.
Oh, my bad. Totally fine with the Thread.sleep then.
...cipant-integration-api/src/main/scala/platform/apiserver/services/tracking/TrackerImpl.scala
Outdated
Show resolved
Hide resolved
hanshoglund-da
approved these changes
Oct 8, 2020
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timer to track queue delay in InstrumentedSource.queue and use it from TrackerImpl.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.