Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for concurrent commands [KVL-583] #7575

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

rautenrieth-da
Copy link
Contributor

This PR adds metrics for measuring the concurrency of the following running actions:

  • Submission service submissions (SubmissionService.submit(), from request to response)
  • Command execution (total, including data fetching and time model iterations)
  • Execution engine (pure command execution, excluding data fetching)
  • WriteService submissions (WriteService.submitTransaction())

@ghost
Copy link

ghost commented Oct 6, 2020

We don't have proper documentation for metrics right now, but we do document them in the the DAML on PostgreSQL documentation. Could you update that, and add a CHANGELOG entry?

CHANGELOG_BEGIN
CHANGELOG_END
CHANGELOG_BEGIN
- [DAML on SQL] Add new metrics for measuring the number
  of concurrent command executions. The metrics are:
  daml.commands.submissions_running, daml.execution.total_running,
  daml.execution.engine_running
CHANGELOG_END
@rautenrieth-da rautenrieth-da force-pushed the kvl-583-concurrent-commands-metrics branch from 46cb622 to fa83034 Compare October 6, 2020 12:03
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@rautenrieth-da rautenrieth-da merged commit 0c1cadc into master Oct 6, 2020
@rautenrieth-da rautenrieth-da deleted the kvl-583-concurrent-commands-metrics branch October 6, 2020 19:09
cocreature pushed a commit that referenced this pull request Oct 7, 2020
* Add metrics for concurrent commands

* Update readme

CHANGELOG_BEGIN
- [DAML on SQL] Add new metrics for measuring the number
  of concurrent command executions. The metrics are:
  daml.commands.submissions_running, daml.execution.total_running,
  daml.execution.engine_running
CHANGELOG_END
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant